search

k3s-io / kine

Run Kubernetes on MySQL, Postgres, sqlite, dqlite, not etcd.
Apache License 2.0
1.54k stars 231 forks source link

Install goimports from commit hash instead of tag #177

Closed matttrach closed 1 year ago

matttrach commented 1 year ago

This enables the use of go proxy and module cache for the goimports install by installing the commit hash at HEAD where the tag is. If we install from the commit hash we no longer need to bypass the proxy and we will benefit from the extra resilience.

The earlier trade-off was the intent to keep things easier to update by using a human identifiable tag name and lose the benefits of the go proxy and module cache. I am generating automation which will keep the version up to date more easily, so I want to resolve the go proxy issue. I want this to resolve first to avoid duplicate effort as I need to update automation to keep the hash up to date after this change.

For human readability I am adding a comment with the corresponding tag version, this allows humans to easily validate the automation.

matttrach commented 1 year ago

looks like the CI was skipped (maybe a problem with the runners?) restarting