search

k3s-io / kine

Run Kubernetes on MySQL, Postgres, sqlite, dqlite, not etcd.
Apache License 2.0
1.54k stars 231 forks source link

Update NATS to v2.9.18 #192

Closed bruth closed 1 year ago

brandond commented 1 year ago

I see that CI has failed, is there anything interesting related to this change in the log?

bruth commented 1 year ago

I forgot to update the actual test script for external NATS, so just did that.

I looked at the failure and tried to track down where/why it would occur, but impacts the older NATS server versions (2.7.x, and 2.8.x, no longer recommended to use). Is there a standard policy arounds backwards compat for kine drivers?

That said personally I want to understand what changed in, where I suspect, the Go NATS library causing the older server versions to fail..

bruth commented 1 year ago

Got info on the bug reported here: https://github.com/nats-io/nats.go/issues/1321 and fixed here: https://github.com/nats-io/nats.go/pull/1325. Patch release coming this week, so we can wait to merge this until I bump the Go client with the fix.