search

k3s-io / kine

Run Kubernetes on MySQL, Postgres, sqlite, dqlite, not etcd.
Apache License 2.0
1.5k stars 228 forks source link

Fix SQLLog.compactor #209

Closed hangscer8 closed 10 months ago

hangscer8 commented 11 months ago

Because it will cause memory leak if we do not stop ticker when the function has completed.

brandond commented 10 months ago

Sure, but this goroutine never exits unless the whole process is terminating. Have you run into any circumstances where this actual causes a leak of the timer?

hangscer8 commented 10 months ago

@brandond I think you are right, this pr just keeps code normal.