Provide Dapper free build alternative - Githubissues

k3s-io / kine

Run Kubernetes on MySQL, Postgres, sqlite, dqlite, not etcd.

Apache License 2.0

1.5k stars 228 forks source link

Provide Dapper free build alternative #254

Closed dereknola closed 6 months ago

dereknola commented 7 months ago

Signed-off-by: Derek Nola derek.nola@suse.com

Changes

Add make no-dapper which uses a regular multistage docker build to match dapper functionality.
Consolidate the two validate scripts into one
Bump dapper image in CI
Nit: Spelling mistakes fixed

Performance

Kine already builds quickly, so the goal was to match performance.

	Change	dapper	no-dapper
Run 1	Clean build (clean docker image/cache)	1m28s	1m33s
Run 2	Tagged build	18.7s	8.5s
Run 3	skip validate, code change my.sql:119	9.7s	8.4s
Run 4	no change (test caching efficiency)	10.3s	5.3s

brandond commented 7 months ago

merge when ready!