search

k3s-io / kine

Run Kubernetes on MySQL, Postgres, sqlite, dqlite, not etcd.
Apache License 2.0
1.65k stars 237 forks source link

Minimal sample and minor tweak to listener #28

Closed ibrokethecloud closed 4 years ago

ibrokethecloud commented 4 years ago

The PR contains the following:

  1. A sample minimal config to use kine with rke based on a external etcd endpoint served by kine.

  2. Kine endpoint is not secured using tls. There is a change to endpoints.go to use the same cert used for communication with a database to secure kine endpoint.

If needed I can tweak the code to add extra flags to specify a different cert for kine endpoint. This would be more beneficial as this will allow users to use two sets of certs for encrypting backend and endpoint traffic.

erikwilson commented 4 years ago

thanks for the PR @ibrokethecloud! I think the code change is okay, altho we may want to gate the behavior behind the flag.

my personal feeling is that examples should not contain static credentials, so it would be better to include a script to generate them.

the commits should be "fixed up"/rebased to two commits, one for the code change and one for the sample.

feel free to ping myself or @cjellick, in PRs or slack, if it helps to get this stuff moving.