k3s-io / kine

Run Kubernetes on MySQL, Postgres, sqlite, dqlite, not etcd.
Apache License 2.0
1.49k stars 226 forks source link

MariaDB in README #300

Open robertsilen opened 1 month ago

robertsilen commented 1 month ago

Any reason MariaDB is not mentioned in the list of databases in the README? Could it be added?

brandond commented 1 month ago

We're kinda just listing the backend drivers that we support: https://github.com/k3s-io/kine/blob/edd8f35371395a3b0c4ea229061f46807855bed7/pkg/endpoint/endpoint.go#L31-L37

Since there is no mariadb-specific driver, we don't call it out. If you wanted to open a PR to call it mysql/mariadb in the readme that would probably be accepted.

robertsilen commented 1 month ago

Thanks @brandond , makes sense, I opened PR https://github.com/k3s-io/kine/pull/303