fix: only log slow sql query parameters if trace logging is enabled

k3s-io / kine

Run Kubernetes on MySQL, Postgres, sqlite, dqlite, not etcd.

Apache License 2.0

1.63k stars 234 forks source link

Closed mezgerj closed 3 months ago

mezgerj commented 3 months ago

This corrects https://github.com/k3s-io/kine/issues/305 by only dumping the sql query parameters in the slow sql log if the log level is set to trace.

brandond commented 3 months ago

lgtm, thanks!

mezgerj commented 3 months ago

@brandond thanks for the review. What is the process to get this merged?

vitorsavian commented 3 months ago

hey @mezgerj, the process of merging is that any PR need two approvals, after the two approvals one of the devs can go and merge.

I'll merge your PR, tks for the contribution!!