search

k3s-io / kine

Run Kubernetes on MySQL, Postgres, sqlite, dqlite, not etcd.
Apache License 2.0
1.54k stars 231 forks source link

Changing the RV semantics in Upstream Kubernetes #309

Open nilekhc opened 1 month ago

nilekhc commented 1 month ago

We are codifying the schema of ResourceVersion in upstream Kubernetes with KEP.

tl;dr With this change, we are parsing ResourceVersion to an int, thus explicitly defining RV as an integer rather than an opaque string as it is today. Does this affect the project in any way?

brandond commented 1 month ago

I think we should be fine - our db schema and interfaces define it as int64: https://github.com/k3s-io/kine/blob/b6a31549dcc8dee9e893721495e5852b0fa648ae/pkg/logstructured/logstructured.go#L19-L30

Does defining it as int instead of int64 have any impact on 32bit platforms like arm, where int will be int32 instead of int64? We do still support arm...