search

k4m4 / terminals-are-sexy

💥 A curated list of Terminal frameworks, plugins & resources for CLI lovers.
https://terminalsare.sexy/
Creative Commons Zero v1.0 Universal
12.25k stars 606 forks source link

Broken link from "Edit on GitHub" button #207

Closed Nklya closed 5 years ago

Nklya commented 5 years ago

Hello.

I've found that link from "Edit on GitHub" button is broken. It goes to https://github.com/k4m4/terminals-are-sexy/edit/master/docs/index.md, but this file is not available and thus gets 404.

Nklya commented 5 years ago

It's still broken https://github.com/k4m4/terminals-are-sexy/blob/master/readme.md/index.md

k4m4 commented 5 years ago

Yep, I noticed. Working on it! Thanks for bringing it up!

k4m4 commented 5 years ago

Seems that mkdocs has the filename index.md as its default config and appends it to the end of the directory that you set in your edit_uri variable. Looking for a way to change the default filename value to readme.md.

k4m4 commented 5 years ago

Fixed in 2b1767b. In conclusion, I feel that the plain GitHub link is more appropriate. Thanks again.