hoanle
commented
8 years ago @k4netmt :+1: nice work. A few notes after checking out the code:
- Properly reused the single base method in search activity to fetch results for both initial load and the pagination
- Nice to see you added the search box to the ActionBar! Also it surprised me that you put the Desk options to the side menu.
- Properly used spinners (with populated values) or checkboxes to allow users to select filters
- Good to see you used a filters object to represent the filters to apply to the query
- Consider adding the ability to share a news article. This is an important learning for this assignment even though it's optional.
- Try out the third-party ButterKnife library to simplify a lot of boilerplate findViewById() calls.
- Since your code work fine, maybe you could think of improving code quality, try new things. How about trying new API lib like Retrofit or Volley?
- One more advice, you should arrange code in a cleaner style, put code into smaller function for reader to read easily.
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
k4netmt
Hi @hoanle and /cc @coderschoolreview, I have completed home work Assignment Week 2. Please check it help me. Thanks you very much!