k4netmt / TodoCoder

To do code

0 stars 0 forks source link

Submitting To do app Homework with 2 optional #2

Open k4netmt opened 8 years ago

k4netmt commented 8 years ago

Here is my completed homework assignment! Thanks you. /cc @coderschoolreview

hoanle commented 8 years ago

hi @k4netmt

Thanks for the submission

In general:

The app works fine without any critical issue (like crash app)
Require features are done
You wrote your own adapter class, used SQLiteDatabase for storage. I like your DataProvider package

Details & Suggestions:

Why don't you try with DialogFragment
You can use Serializable on TodoListDTO and then freely pass it through activities. Don't need to pass each field pf TodoListDTO object
In Adapter, using a ViewHolder can improve the performance
After using a cursor, connection, you should close it
One more suggestion: I feel it's not common to name the functions like the way you did. For example: OnAddItems should be better with onAddItems, SetLevel => setLevel

k4netmt commented 8 years ago

hi @hoanle . Thanks you very much, spent time to check my source code. Please, confirm help me. Have I complete the require to come to class Android of Coderschool on October 08/03 ? If not, what do I do next. I very look forward to participate in this class. I will try to complete your suggestions. Thanks you very much.

hoanle commented 8 years ago

Hi @k4netmt

if you have any update, commit it today :)

k4netmt commented 8 years ago

Hi @hoanle

TodoCoder Demo 01-03-2016

Time spent: 2 hours spent in total

Apply ViewHolder in Adapter, solution can improve the performance.
After using a cursor and connection close it.
Change name the function correct standard.
Add feature Sort todolist by Level follow cause Desc.

Thanks you very much! I hope my have place in class Androidn of Coderschool.

hoanle commented 8 years ago

@k4netmt Thanks. We will announce the result soon by email

chug2k commented 8 years ago

HI there @k4netmt! I'm trying to announce the result by email, but I can't find you in our system anywhere. Can you please send an email to android {at} coderschool.vn telling me that you are k4netmt? This seems to be a different github account than the one you used to apply to CoderSchool.

k4netmt commented 8 years ago

Hi @chug2k , I have send contact and re-register class Android on 8/3/2016. Please confirm help me, you receive an email. Thanks you very much! I hope my have place in class Androidn of Coderschool.