search

k4yt3x / video2x

A machine learning-based lossless video super resolution framework. Est. Hack the Valley II, 2018.
https://video2x.org
GNU Affero General Public License v3.0
10.7k stars 1k forks source link

Do not support the decimals for upscaled factor? #6

Closed pokedo0 closed 6 years ago

pokedo0 commented 6 years ago

Do not support the decimals for upscaled factor?

pokedo0 commented 6 years ago

in the meantime, there is some problem occuring as merging the pics to video. Imgur Imgur However, i successfully get the upscaled video at last.

k4yt3x commented 6 years ago

@pokedo0 Thank you for your issue!

The issue seems to me is that it's failing to merge the audio with the finished video. I am aware of that issue and I have been experimenting with it to see if I can solve it. If you check the destination that you specified for audio output, you should see a video file. If not, let me know.

The upscale factor doesn't support a decimal. I'm still hesitating whether to use a factor number or just use a target resolution (e.g. 1920x1080) as waifu2x wants the parameter to be. (or both?)

I will look into the issues and give you another response ASAP. Sorry if my fixes are delayed since I'm fairly busy recently :P

pokedo0 commented 6 years ago

the audio seems crashed and the video track is ok. the factor supports decimals for the offical waifu2x cafee, right?

k4yt3x commented 6 years ago

The audio issue didn't exist when I first developed this script. I will have it fixed. Waifu2x caffe, I think, only supports the [length]x[height] format, but I'll double check that.

k4yt3x commented 6 years ago

@pokedo0 Hi I have just pushed the newest version of video2x. Video2x will now take a resolution as output video dimentions just as how waifu2x wants it, instead of using a "factor".

I have also solved the audio issue in the newest version. Try if it works!

pokedo0 commented 6 years ago

All problem have been solved. Thx~

k4yt3x commented 6 years ago

@pokedo0 good to hear! You're welcome. I'm closing the issue then.