k4yt3x / video2x

A machine learning-based lossless video super resolution framework. Est. Hack the Valley II, 2018.
https://video2x.org
GNU Affero General Public License v3.0
10.7k stars 1k forks source link

Help starting out? #7

Closed WSADKeysGaming closed 6 years ago

WSADKeysGaming commented 6 years ago

Hi, Is this for linux or windows? Python doesn't support git cloning or change directory, but it is mentioned thru the instructions and tags.

k4yt3x commented 6 years ago

Hello @WSADKeysGaming. This software is designed for Windows since it uses waifu2x-caffe. We currently have no plans migrating it to Linux.

Note that there's a dollar sign ($) in front of the git commands. That indicates that the command is a shell command instead of a python command. You are supposed to clone the repository with a Windows Git client. Alternatively, you may also download the repo as a zip file.

Does that answer your question?

WSADKeysGaming commented 6 years ago

Sudo is not recognized as a command in git, and I figured out myself that pip must be installed into git, it doesn't come standard. You should have that as a prerequisite, or a bash line before the rest of the commands.

On Tue, Aug 21, 2018, 4:40 PM K4YT3X notifications@github.com wrote:

Hello @WSADKeysGaming https://github.com/WSADKeysGaming. This software is designed for Windows since it uses waifu2x-caffe. We currently have no plans migrating it to Linux.

Note that there's a dollar sign ($) in front of the git commands. That indicates that the command is a shell command instead of a python command. You are supposed to clone the repository with a Windows Git client. Alternatively, you may also download the repo as a zip file.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/K4YT3X/video2x/issues/7#issuecomment-414830661, or mute the thread https://github.com/notifications/unsubscribe-auth/Ags0tM1JvoJI1siVv36G0eevkvBYUYL0ks5uTH4ygaJpZM4WF-Yj .

k4yt3x commented 6 years ago

@WSADKeysGaming that's my bad. You shouldn't need sudo if you're using pip for windows. I use Linux as my major OS, so I confused the two while writing the tutorial.

I will change that right now.

============ Update I have already updated the README file. Please take a look.

WSADKeysGaming commented 6 years ago

I'm sorry, even though you can download the repo as a zip and not through the git program, is it still required to use the change directory command that is mentioned in the first line of instructions?

On Sun, Aug 26, 2018, 4:20 PM K4YT3X notifications@github.com wrote:

Closed #7 https://github.com/K4YT3X/video2x/issues/7.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/K4YT3X/video2x/issues/7#event-1809513463, or mute the thread https://github.com/notifications/unsubscribe-auth/Ags0tP_vk2gJwG14YajbHUx9nPeG8Jz8ks5uUxEWgaJpZM4WF-Yj .

k4yt3x commented 6 years ago

Nah just make sure you're in the same directory as where all the .py files are and you're good to go.

WSADKeysGaming commented 6 years ago

That's with the command ">Import os

os.chdir(c:/users/david/documents/video2x-master)"

Right? I'm still learning python, sorry

On Mon, Oct 22, 2018, 5:57 PM K4YT3X notifications@github.com wrote:

Nah just make sure you're in the same directory as where all the .py files are and you're good to go.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/K4YT3X/video2x/issues/7#issuecomment-432020320, or mute the thread https://github.com/notifications/unsubscribe-auth/Ags0tH_UQNSjfA0YwJQfOr3a90Bf6xBaks5unk1GgaJpZM4WF-Yj .

k4yt3x commented 6 years ago

You're supposed to run the software from the windows cmd, not within the Python interactive shell. This screenshot might help a bit.

screenshot

WSADKeysGaming commented 6 years ago

Boy am I an idiot. Thanks. Saved me from going back to the project I mentioned before.

On Mon, Oct 22, 2018, 6:27 PM K4YT3X notifications@github.com wrote:

You're supposed to run the software from the windows cmd, not within the Python interactive shell. This screenshot might help a bit.

[image: screenshot] https://user-images.githubusercontent.com/21986859/47325139-797fe800-d630-11e8-9c97-8d0d5b03b002.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/K4YT3X/video2x/issues/7#issuecomment-432026946, or mute the thread https://github.com/notifications/unsubscribe-auth/Ags0tH0PBAS0YhIutIDVNm9LhK4QI6Znks5unlRfgaJpZM4WF-Yj .