search

k4yt3x / wg-meshconf

WireGuard full mesh configuration generator.
GNU General Public License v3.0
938 stars 105 forks source link

Added the .editorconfig according to PEP 8 #19

Closed KOLANICH closed 3 years ago

k4yt3x commented 3 years ago

Not a necessary ingredient. This is up to the editor and some personal preference. I don't see a point including it in the repo.

KOLANICH commented 3 years ago

It seems you deeply misunderstand what .editorconfig is.

This is up to the editor

.editorconfig was designed to be cross-editor.

and some personal preference.

All projects enforce personal preferences of their authors. Especially in python, which disallows mixing tabs and spaces. I.e. if someone sends you a PR when the changed lines use tabs instead of spaces, then it is likely that

  1. that code won't even work, python enforces consistency;
  2. even if it worked, you will still demand replacing tabs with spaces.

The contributor will say then: "But my editor configured to use tabs, I won't change my editor preferences only because your project uses spaces".

.editorconfig files do that for him. In the editors im0lementing the spec or having the plugins implementing the spec installed, of course.

k4yt3x commented 3 years ago

.editorconfig was designed to be cross-editor.

Yeah I didn't look that up. Sorry I'm trying to stay awake right now after a night without sleep.

This repository strictly requires all code to be formatted with Black formatter. I don't think it'll make any differences?

KOLANICH commented 3 years ago

It makes editing more convenient.

k4yt3x commented 3 years ago

Perhaps, I've never needed it. It still doesn't make sense to me to have this extra file in the repository. It looks redundant to me.