k82l0804 / slimdx

Automatically exported from code.google.com/p/slimdx
MIT License
0 stars 0 forks source link

SlimDX.Direct3D9.Device.CreateRenderTarget(...) sharedHandle as [ref] instead of [out] #886

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The method SlimDX.Direct3D9.Device.CreateRenderTarget() takes a  parameter 
called "sharedHandle" for sharing renderTargets between processes.

Currently this parameter is set as an out param.

http://slimdx.org/docs/html/M_SlimDX_Direct3D9_Surface_CreateRenderTarget_1.htm

However I think this should actually be a ref, as it can be used as both an 
input or an outoput to the method.

http://msdn.microsoft.com/en-us/library/windows/desktop/bb174361(v=vs.85).aspx

Could this be changed?
Thanks

Original issue reported on code.google.com by chris.ba...@gmail.com on 2 Nov 2012 at 8:30

GoogleCodeExporter commented 9 years ago
Just to note, the Texture constructor has implemented this parameter correctly

http://slimdx.org/docs/html/M_SlimDX_Direct3D9_Texture__ctor_3.htm

Original comment by chris.ba...@gmail.com on 5 Nov 2012 at 3:23

GoogleCodeExporter commented 9 years ago
Indeed. Simple fix.

Original comment by Mike.Popoloski on 5 Nov 2012 at 4:21

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2210.

Original comment by Mike.Popoloski on 24 Jan 2013 at 3:58