k8s-at-home / charts

⚠️ Deprecated : Helm charts for applications you run at home
https://docs.k8s-at-home.com
Apache License 2.0
1.45k stars 623 forks source link

[uptime-kuma] Fixed bug in uptime kuma values.yaml regarding persistence #1529

Closed maxemann96 closed 2 years ago

maxemann96 commented 2 years ago

Description of the change Changed the key persistence.data to persistence.config in values.yaml

Benefits Users without any prior knowledge of k8s@home charts are now easier be able to deploy this chart with persistence

Possible drawbacks no

Applicable issues no one

Additional information

Checklist

bjw-s commented 2 years ago

I'm not entirely sure what the exact bug is here that you are trying to fix.

It's only the name of the volume that gets set within the Pod, and the mountPoint seems to indicate that it contains application data?

maxemann96 commented 2 years ago

As far as I understand the persistence configuration of the common library used as dependency in this chart, it is needed to configurate the persistence under the key persistence.config and not persistence.data as stated in the values.yaml before.

maxemann96 commented 2 years ago

Got now how it's working. The initial error lead me to this change was that "accessMode is not defined for pvc ..." and I was searching for a solution why it not works. I found no documentation, that persistence.x is just a key defining the name of the pvc and was irritated, because the common chart template only documents the config key with some default values and I thought that there are then default values for all other keys than config or the key is wrong.

Thanks for your patience

bjw-s commented 2 years ago

No worries! Glad you got your initial issue sorted and thank you for wanting to submit a fix!