[Rhasspy] New chart for the amazing offline voice assistant

k8s-at-home / charts

⚠️ Deprecated : Helm charts for applications you run at home

https://docs.k8s-at-home.com

Apache License 2.0

1.45k stars 623 forks source link

[Rhasspy] New chart for the amazing offline voice assistant #1577

Closed ntrp closed 2 years ago

ntrp commented 2 years ago

Description of the change

Add a new chart

Benefits

We have home automation chart like zigbee2mqtt and home assistant, this one fits perfectly the ecosystem

Possible drawbacks

No known issues

Applicable issues

fixes #

Additional information

Checklist

[x] Title of the PR starts with chart name (e.g. [home-assistant])
[x] Chart version bumped in Chart.yaml according to semver.
[x] Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
[x] Variables have been documented in the values.yaml file.

truxnell commented 2 years ago

Thanks for the PR @ntrp

Your PR is failing lint & a test-install - can you have a look and review?

ntrp commented 2 years ago

Hi, sorry, I have seen it but it was a busy period. Should be able to have a look on it this weekend

ntrp commented 2 years ago

I fixed a couple of issues and signed off commits but there is one problem I am not sure how to fix.. The maintainer is shown as not found, how should I set it? I cannot find anything in the contributing section.

truxnell commented 2 years ago

Just a hunch, it might be as you have used spaces in your name - perhaps try "Ivan Greguric Ortolan" (or use your github handle if you prefer, real name isn't required)

ntrp commented 2 years ago

Ok I am not sure what to put into the maintainer field.. Looks like it has to be in a list to work but I cannot find any docu about this. If anybody else can shine some light would be great.

Preisschild commented 2 years ago

From the chart-testing source code: https://github.com/helm/chart-testing/blob/3c014d8d385ae03dc9e040c93ce71bcdf76a38eb/pkg/chart/chart.go#L841

It appears that chart-testing validates the names against GitHub accounts, so you need to put in your github account name (ntrp) under name.

Thanks for creating the chart btw, I want to deploy Rhasspy as well.

truxnell commented 2 years ago

@all-contributors please add @ntrp for code

truxnell commented 2 years ago

@all-contributors please add @ntrp for code

allcontributors[bot] commented 2 years ago

@Truxnell

I've put up a pull request to add @ntrp! :tada:

truxnell commented 2 years ago

Thanks for the chart @ntrp! :tada: