[mqtt-exporter] Add new chart

k8s-at-home / charts

⚠️ Deprecated : Helm charts for applications you run at home

https://docs.k8s-at-home.com

Apache License 2.0

1.45k stars 623 forks source link

[mqtt-exporter] Add new chart #1584

Closed runningman84 closed 2 years ago

runningman84 commented 2 years ago

Description of the change

Benefits

Possible drawbacks

Applicable issues

fixes #

Additional information

Checklist

[x] Title of the PR starts with chart name (e.g. [home-assistant])
[x] Chart version bumped in Chart.yaml according to semver.
[x] Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
[x] Variables have been documented in the values.yaml file.

runningman84 commented 2 years ago

@bjw-s @onedr0p @billimek is anybody able to merge this...?

bjw-s commented 2 years ago

@runningman84 It's not really appreciated to be tagging us this quickly. We are all people that do this for fun in our free time, while juggling other life responsibilities.

This means that sometimes a PR will sit a bit longer, sometimes it'll be done in 5 minutes.

runningman84 commented 2 years ago

okay I hope all request changes are included now.

Would you like having secure defaults?

securityContext:
  capabilities:
    drop:
     - ALL
  readOnlyRootFilesystem: true
  runAsNonRoot: true
  runAsUser: 65534

bjw-s commented 2 years ago

okay I hope all request changes are included now.

Looks like it, although the chart is still excluded from the install phase, so the additionalContainer ct-values file is not being tested now I think.

Would you like having secure defaults?

securityContext:
  capabilities:
    drop:
     - ALL
  readOnlyRootFilesystem: true
  runAsNonRoot: true
  runAsUser: 65534

That sounds like a good idea :-)

runningman84 commented 2 years ago

is there anything else left?