[send] Added timvisee Send chart

k8s-at-home / charts

⚠️ Deprecated : Helm charts for applications you run at home

https://docs.k8s-at-home.com

Apache License 2.0

1.45k stars 623 forks source link

[send] Added timvisee Send chart #1586

Closed geraldwuhoo closed 2 years ago

geraldwuhoo commented 2 years ago

Signed-off-by: geraldwuhoo gerald@geraldwu.com

Description of the change

Add Send chart

Benefits

People will be able to deploy Send, a simple drag-and-drop file sharing service with client-side encryption.

Possible drawbacks

Applicable issues

Additional information

Checklist

[x] Title of the PR starts with chart name (e.g. [home-assistant])
[x] Chart version bumped in Chart.yaml according to semver.
[x] Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
[x] Variables have been documented in the values.yaml file.

geraldwuhoo commented 2 years ago

Thanks! For future reference, why not include the tag in the base values.yaml?

bjw-s commented 2 years ago

Thank you for updating!

Thanks! For future reference, why not include the tag in the base values.yaml?

The reason for this is that the value gets populated by the appVersion field from Chart.yaml metadata by default when the field is empty. We had quite some charts in the past where the appVersion metadata would differ from the image.tag value. So by leaving it empty by default we ensure that they are always in sync (and only have to update the application version in one spot) :) Users can still manually override/pin the value by specifying a value themselves.

bjw-s commented 2 years ago

@all-contributors Please add @geraldwuhoo for code

allcontributors[bot] commented 2 years ago

@bjw-s

I've put up a pull request to add @geraldwuhoo! :tada: