k8s-at-home / charts

⚠️ Deprecated : Helm charts for applications you run at home
https://docs.k8s-at-home.com
Apache License 2.0
1.45k stars 623 forks source link

[prometheus-nut-exporter] Set `instance` label instead of `target`. #1638

Closed reitermarkus closed 2 years ago

reitermarkus commented 2 years ago

Description of the change

As far as I understand, Grafana groups by instance by default, so each NUT server should be in instance, otherwise instance will change with every pod rescheduling. This results in UPSs not being grouped when they should be.

Benefits

This makes the example Grafana dashboard work by default.

Possible drawbacks

Breaking change needs major version bump. Maybe I'm also understanding something wrong, since no chart in this repo currently replaces the instance label.

Applicable issues

N/A

Additional information

Checklist

reitermarkus commented 2 years ago

I guess I misunderstood, since the pod label also changes and causes it to not group correctly.