search

k8s-land / gitea-chart

Gitea Helm Chart
https://charts.k8s.land
MIT License
31 stars 15 forks source link

Keeping example app.ini up to date #17

Open bjw-s opened 4 years ago

bjw-s commented 4 years ago

Currently a version of app.ini is made available through templates/gitea/gitea-config.yaml.

The contents of this file is prone to change as new versions of Gitea are released, which would mean the configmap would have to change accordingly. For example, the SHOW_MILESTONES_DASHBOARD_PAGE key is available in the official sample file, but it is not in the configmap.

If I understand the documentation correctly, it is possible to only define the values in the file that you actually wish to customize.

Following that approach, maybe the configmap should be simplified to just read the config key from values.yaml. The only thing I'm not sure of is how the database and gitea secrets should be automatically injected into the configuration file.

Hopefully this issue can be used to discuss this.

Nox-404 commented 4 years ago

Hi there, Would be best to be able to set everything from values.yaml I agree, I can make a PR if needed Something like that would be great:

config: |
  < the config >
  DB_TYPE: {{ .Values.externaldb.dbType }}
  ...

or to avoid using the tpl it could be something like that:

config:
  default:
    APP_NAME: Gitea
  ...
  <section>:
    <key>: <value>

and provide defaults there, wich gives the user full customization without the hassle of merging the defaults

cdrage commented 4 years ago

Hi @Nox-404 unfortunately I've been pretty busy with work, if you can create a PR that'd be great!

Nox-404 commented 4 years ago

Completely forgot about this, I'll see what I can do over the weekend

cdrage commented 4 years ago

Hey all, I have donated this chart to the folks over at Gitea who have been doing an amazing job maintaining and updating the chart so it is up to date. Please open up any issues here: https://gitea.com/gitea/helm-chart and try theirs own!

Many thanks for all who've contributed.