search

k8s-land / gitea-chart

Gitea Helm Chart
https://charts.k8s.land
MIT License
31 stars 15 forks source link

Fix issue with pod port exposition and add externalIPs #8

Closed rouja closed 4 years ago

rouja commented 4 years ago

Hi,

First of all, nice work !

My pull request contains two things :

1- It's a problem if the ssh (the same for http) port of the service in the values.yml is used in the same time for the ssh port in the pod :

  ssh:
    serviceType: LoadBalancer
    port: 22

and :

  ports:
  - name: ssh
    containerPort: {{ .Values.service.ssh.port  }}
  - name: http
    containerPort: {{ .Values.service.http.port  }}
  livenessProbe:

The port in the pod for ssh is always 22. So if you change the value in the service, you break the pod.

2 - I add the abililty to use externalIPs to expose the service.

Let me know if I have to modify something.

cdrage commented 4 years ago

Hey @rouja thanks for the changes! You're completely right. I'll push a new release with these changes immediately.