Deployment images must use canonical names

k8s-proxmox / cluster-api-provider-proxmox

Cluster API provider implementation for Proxmox VE

Apache License 2.0

103 stars 11 forks source link

Closed daper closed 1 year ago

sp-yduck commented 1 year ago

Thank you for the PR ! could you also updates here as well ? https://github.com/sp-yduck/cluster-api-provider-proxmox/blob/main/templates/cluster-template.yaml#L231 this image is for CCM in the workload cluster.

daper commented 1 year ago

I have updated that as well, but I think that was fine as it is the cluster-api provider contract who enforces it only.

sp-yduck commented 1 year ago

I see. anyways it's better to use canonical name. thank you !