k8s-proxmox / cluster-api-provider-proxmox

Cluster API provider implementation for Proxmox VE
Apache License 2.0
103 stars 11 forks source link

Add ownerReference to secrets #52

Closed sp-yduck closed 1 year ago

sp-yduck commented 1 year ago

the secrets storing proxmox auth credentials should have ownerReference (for ProxmoxCluster) so that they can be removed properly when owner object is deleted (reference : https://cluster-api.sigs.k8s.io/reviewing?highlight=owner#owner-references) https://github.com/sp-yduck/cluster-api-provider-proxmox/blob/1d70f39ce5661405f4069e477aa1fa20ee6598f9/cloud/scope/clients.go#L35-L45