search

k8sgateway / k8sgateway

The Cloud-Native API Gateway and AI Gateway
https://k8sgateway.io/
Apache License 2.0
4.12k stars 449 forks source link

`glooctl check` should check license #3520

Open srenatus opened 4 years ago

srenatus commented 4 years ago

Describe the bug

When our trial license was expired, or when you mistakenly pass an invalid license to glooctl install, it manifests in a broken observability service, and in its logs, you'll see something complaining about the bad (or expired) license.

This is not as obvious as it should be, I suppose. Could glooctl check check the license, maybe?

To Reproduce Steps to reproduce the behavior:

  1. glooctl install with a bad license, or have your trial license expire
  2. glooctl check returns OK
  3. The logs of observability mention the bad license.

Expected behavior glooctl check should yell if the license is bad or expired.

Additional context

$ glooctl version
Client: {"version":"1.4.10"}
Server: {"type":"Gateway","enterprise":true,"kubernetes":{"containers":[{"Tag":"1.4.10","Name":"grpcserver-ui","Registry":"quay.io/solo-io"},{"Tag":"1.4.10","Name":"grpcserver-ee","Registry":"quay.io/solo-io"},{"Tag":"1.4.10","Name":"grpcserver-envoy","Registry":"quay.io/solo-io"},{"Tag":"1.4.11","Name":"discovery","Registry":"quay.io/solo-io"},{"Tag":"1.4.10","Name":"extauth-ee","Registry":"quay.io/solo-io"},{"Tag":"1.4.11","Name":"gateway","Registry":"quay.io/solo-io"},{"Tag":"1.4.10","Name":"gloo-ee-envoy-wrapper","Registry":"quay.io/solo-io"},{"Tag":"1.4.10","Name":"gloo-ee","Registry":"quay.io/solo-io"},{"Tag":"1.4.10","Name":"observability-ee","Registry":"quay.io/solo-io"},{"Tag":"1.4.10","Name":"rate-limit-ee","Registry":"quay.io/solo-io"},{"Tag":"5","Name":"redis","Registry":"docker.io"}],"namespace":"gloo-system"}}
kdorosh commented 4 years ago

adding this to glooctl check is a good UX improvement, would also like to add this to gloo as its own API

github-actions[bot] commented 11 months ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.

github-actions[bot] commented 1 month ago

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.