k8snetworkplumbingwg / ib-sriov-cni

InfiniBand SR-IOV CNI
Other
42 stars 27 forks source link

Rdma ns aware support #17

Closed adrianchiris closed 4 years ago

adrianchiris commented 4 years ago

This PR adds support for network namespace isolation for RDMA devices.

This PR is required as current kernel model is to recreate IPoIB netdevices (it actually recreates all ULP resources associated with it causing the IPoIB netdevice to recreate) in default namespace when RDMA device is moved to a namespace.

hence in contrast to Ethernet case where one would use SR-IOV CNI and RDMA CNI in a chain to achieve this. Here we need to surgically add support.

If/When a better model is introduced in kernel, the code may be removed.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 23


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/rdma.go 0 48 0.0%
<!-- Total: 0 48 0.0% -->
Totals Coverage Status
Change from base Build 50: -5.4%
Covered Lines: 120
Relevant Lines: 251

💛 - Coveralls
adrianchiris commented 4 years ago

Did Mamduh test it? He started to. pod is created /destroyed as expected.

Mmduh-483 commented 4 years ago

Did Mamduh test it? He started to. pod is created /destroyed as expected.

@moshe010 I sent the full testing report this morning, @adrianchiris check issue 3 it is critical