k8snetworkplumbingwg / ib-sriov-cni

InfiniBand SR-IOV CNI
Other
42 stars 27 forks source link

Run Unbind/Bind VF in a serial manner. #30

Closed adrianchiris closed 4 years ago

adrianchiris commented 4 years ago

Unbind/Bind VF as well as moving RDMA device to namespace causes rdma resources to be re-created. CNI may be invoked in parallel and kernel may provide a VF RDMA resources under a different name.

As the mapping of RDMA resources is done in Device plugin prior to CNI invocation, it must not change during CNI invocation.

We serialize the CNI's Add,Del operations by Creating/Locking/Unlocking a file, causing kernel to allocate RDMA resources the same name for a given VF.

In the future, Systems should use udev PCI based RDMA device names, ensuring consistent RDMA resources names.

adrianchiris commented 4 years ago

Missing testing on a real system

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 72


Totals Coverage Status
Change from base Build 95: 0.0%
Covered Lines: 214
Relevant Lines: 501

💛 - Coveralls
moshe010 commented 4 years ago

please fix lint errors

adrianchiris commented 4 years ago

forgot to push :\ it should pass now