k8snetworkplumbingwg / ib-sriov-cni

InfiniBand SR-IOV CNI
Other
40 stars 27 forks source link

Skip guid config if no guid passed in the conf #41

Closed Mmduh-483 closed 4 years ago

Mmduh-483 commented 4 years ago

Prevent cni failing if no guid pass and skip guid configuring which supports deployments that rely on GUIDs being pre configured on the VF e.g not using ib-kubernetes to allocate guids and want to allow CNI to set up the VF without GUID configuration

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 124


Totals Coverage Status
Change from base Build 94: 0.0%
Covered Lines: 214
Relevant Lines: 501

💛 - Coveralls
adrianchiris commented 4 years ago

can you explain in the commit message why the commit is needed as well?

adrianchiris commented 4 years ago

Overall PR is good, just need a more informative commit messge :)

Mmduh-483 commented 4 years ago

Overall PR is good, just need a more informative commit messge :)

@adrianchiris updated the commit message

adrianchiris commented 4 years ago

So regarding the commit message, can you add why we would like the CNI to not fail ?

i.e for deployments that rely on GUIDs being pre configured on the VF e.g dont use ib-kubernetes to allocate guids we want to allow CNI to set up the VF without GUID configuration

Mmduh-483 commented 4 years ago

@adrianchiris updated the commit message

zshi-redhat commented 4 years ago

How would the VF GUID shall be pre-configured, if not via CNI?

Mmduh-483 commented 4 years ago

@zshi-redhat It can be pre-configured by the user, third-party tool, or the operator (there is a PR for it)