Closed Mmduh-483 closed 4 years ago
Totals | |
---|---|
Change from base Build 94: | 0.0% |
Covered Lines: | 214 |
Relevant Lines: | 501 |
can you explain in the commit message why the commit is needed as well?
Overall PR is good, just need a more informative commit messge :)
Overall PR is good, just need a more informative commit messge :)
@adrianchiris updated the commit message
So regarding the commit message, can you add why we would like the CNI to not fail ?
i.e for deployments that rely on GUIDs being pre configured on the VF e.g dont use ib-kubernetes to allocate guids we want to allow CNI to set up the VF without GUID configuration
@adrianchiris updated the commit message
How would the VF GUID shall be pre-configured, if not via CNI?
@zshi-redhat It can be pre-configured by the user, third-party tool, or the operator (there is a PR for it)
Prevent cni failing if no guid pass and skip guid configuring which supports deployments that rely on GUIDs being pre configured on the VF e.g not using ib-kubernetes to allocate guids and want to allow CNI to set up the VF without GUID configuration