search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
35 stars 33 forks source link

ci, upgrade to admissionregistration.v1 on certs tests #306

Closed RamLavi closed 3 years ago

RamLavi commented 3 years ago

What this PR does / why we need it: PR to upgrade to admissionregistration.v1 when running certificate related CI

Special notes for your reviewer:

Release note:

NONE
RamLavi commented 3 years ago

/cherry-pick release-v0.26

kubevirt-bot commented 3 years ago

@RamLavi: once the present PR merges, I will cherry-pick it on top of release-v0.26 in a new PR and assign it to you.

In response to [this](https://github.com/k8snetworkplumbingwg/kubemacpool/pull/306#issuecomment-851222808): >/cherry-pick release-v0.26 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 3 years ago

/lgtm /approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/master/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 3 years ago

@RamLavi: new pull request created: #307

In response to [this](https://github.com/k8snetworkplumbingwg/kubemacpool/pull/306#issuecomment-851222808): >/cherry-pick release-v0.26 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.