search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
35 stars 33 forks source link

kubectl, Support different cluster root directory #330

Closed oshoval closed 3 years ago

oshoval commented 3 years ago

In order to support CNAO testing of kubemacpool e2e, add an env var, that allows using different cluster root directory, because when CNAO deploys the cluster, it is created on CNAO directory but the kmp tests are running from a temp kmp folder that doesn't have the cluster metadata.

CNAO counterpart https://github.com/kubevirt/cluster-network-addons-operator/pull/988

Signed-off-by: Or Shoval oshoval@redhat.com

None
kubevirt-bot commented 3 years ago

Hi @oshoval. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
oshoval commented 3 years ago

Thanks for the research @RamLavi as we spoke offline, we are falling back to the current solution as the alternatives are problematic,

can you please add ok-to-test ?

phoracek commented 3 years ago

/ok-to-test

RamLavi commented 3 years ago

/lgtm /approve

kubevirt-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)~~ [RamLavi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment