search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
35 stars 33 forks source link

metrics: Use https instead of http #346

Closed oshoval closed 2 years ago

oshoval commented 2 years ago

What this PR does / why we need it: KMP uses controller runtime which creates an http end point for /metrics. In order to support https, we deploy rbac-proxy container in the same pod of KMP. The new container exposes https end point, and connects internally to the http end point.

It is self signed, and protected with rbac rules.

Special notes for your reviewer: Will work offline with Oren Cohen in order to use sha instead of label for the rbac-proxy image. It is needed for downstream.

Release note:

None
oshoval commented 2 years ago

/uncc @RamLavi @ormergi

oshoval commented 2 years ago

/cc @qinqon can you please review ?

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment