search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
35 stars 33 forks source link

DNM: Use controller-runtime client #347

Closed qinqon closed 2 years ago

qinqon commented 2 years ago

Signed-off-by: Quique Llorente ellorent@redhat.com

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

kubevirt-bot commented 2 years ago

@qinqon: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 2 years ago

/hold

DNM

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from qinqon after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qinqon commented 2 years ago

/retest

kubevirt-bot commented 2 years ago

@qinqon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubemacpool-unit-test 7a93bce45dd5963031417787a7bb04960fa82a01 link true /test pull-kubemacpool-unit-test
pull-kubemacpool-e2e-k8s 7a93bce45dd5963031417787a7bb04960fa82a01 link true /test pull-kubemacpool-e2e-k8s
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).