search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
32 stars 33 forks source link

unit tests: Add make check #365

Closed oshoval closed 2 years ago

oshoval commented 2 years ago

What this PR does / why we need it: In order to detect that we don't miss updating files, with make generate, add make check to the unit tests job.

Special notes for your reviewer:

Release note:

None
RamLavi commented 2 years ago

can you push a tmp commit the messes with the fmt check for example?

oshoval commented 2 years ago

can you push a tmp commit the messes with the fmt check for example?

checked locally that make check catch it, and this script has -e but np will test here as well

oshoval commented 2 years ago

reverted the manifests PR and it found it, removing the commit https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/k8snetworkplumbingwg_kubemacpool/365/pull-kubemacpool-unit-test/1505526700451041280#1:build-log.txt%3A126

RamLavi commented 2 years ago

Thanks @oshoval for checking this! /lgtm /approve

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)~~ [RamLavi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment