search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
35 stars 33 forks source link

kubevirtci: Introduce bump script #370

Closed oshoval closed 2 years ago

oshoval commented 2 years ago

What this PR does / why we need it: Built such that automation can use it: In case fatal happens return error code. In case all is good, determine if there was a change according non empty stdout.

Special notes for your reviewer:

Release note:

None
oshoval commented 2 years ago

Thanks Radim @RamLavi Can you take a look please ?

RamLavi commented 2 years ago

cool! Can you also add Makefile target? Also, do you plan to use it from other repos like project-infra?

oshoval commented 2 years ago

Also, do you plan to use it from other repos like project-infra?

We aren't going to do automation at the moment if thats what you mean I don't think it is needed on other repos beside kubevirt It will just add noise

oshoval commented 2 years ago

Added makefile target

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)~~ [RamLavi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment