Closed RamLavi closed 10 months ago
/hold seems like the lane image doesn't have go.
/lgtm /approve we need to install go from automation or prow-jobs
Also add a requirement on the project README
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: qinqon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
New changes are detected. LGTM label has been removed.
@RamLavi: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-kubemacpool-unit-test | 35125e4fe134838f6d2432d9b2020d94f22b3743 | link | true | /test pull-kubemacpool-unit-test |
pull-kubemacpool-e2e-k8s | 35125e4fe134838f6d2432d9b2020d94f22b3743 | link | true | /test pull-kubemacpool-e2e-k8s |
closing this for now. Will revisit later
What this PR does / why we need it: Since we have the go.mod "go" directive it is safe enough to ensure that the golang compiler used has the needed capabilities. This change remove the infra to use a vendored golang tool chain.
Special notes for your reviewer:
Release note: