k8snetworkplumbingwg / kubemacpool

Apache License 2.0
32 stars 33 forks source link

makeFile: Remove vendored go #383

Closed RamLavi closed 10 months ago

RamLavi commented 1 year ago

What this PR does / why we need it: Since we have the go.mod "go" directive it is safe enough to ensure that the golang compiler used has the needed capabilities. This change remove the infra to use a vendored golang tool chain.

Special notes for your reviewer:

Release note:

NONE
RamLavi commented 1 year ago

/hold seems like the lane image doesn't have go.

qinqon commented 1 year ago

/lgtm /approve we need to install go from automation or prow-jobs

Also add a requirement on the project README

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 1 year ago

New changes are detected. LGTM label has been removed.

kubevirt-bot commented 1 year ago

@RamLavi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubemacpool-unit-test 35125e4fe134838f6d2432d9b2020d94f22b3743 link true /test pull-kubemacpool-unit-test
pull-kubemacpool-e2e-k8s 35125e4fe134838f6d2432d9b2020d94f22b3743 link true /test pull-kubemacpool-e2e-k8s
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
RamLavi commented 10 months ago

closing this for now. Will revisit later