search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
32 stars 33 forks source link

makefile, Dockerfile: Move to multi stage build #384

Closed RamLavi closed 11 months ago

RamLavi commented 1 year ago

What this PR does / why we need it: Currently the controller manager is built locally and copied to the Dockerfile. Move to multi-stage docker build.

Special notes for your reviewer:

Release note:

NONE
kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from ramlavi by writing /assign @ramlavi in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 1 year ago

New changes are detected. LGTM label has been removed.

kubevirt-bot commented 11 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.