search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
32 stars 33 forks source link

config: Remove RunasUser field #388

Closed RamLavi closed 1 year ago

RamLavi commented 1 year ago

What this PR does / why we need it: This PR is removing the RunasUser value from the kubemacpool manifests. Using the specific value for runAsUser produces an invalid value error.

Special notes for your reviewer:

Release note:

NONE
kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from ramlavi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oshoval commented 1 year ago

If the problems you saw are on CRC, you might want to see https://github.com/kubevirt/cluster-network-addons-operator/pull/1499

This fixed the problems of KSD on CRC

RamLavi commented 1 year ago

If the problems you saw are on CRC, you might want to see kubevirt/cluster-network-addons-operator#1499

This fixed the problems of KSD on CRC

it was not, the problem was discovered on the tier1 tests of the pipeline watchers team

kubevirt-bot commented 1 year ago

@RamLavi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubemacpool-e2e-k8s 911bb1d8db57ce2947ae12f67a74ca6f71a952b8 link true /test pull-kubemacpool-e2e-k8s
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
RamLavi commented 1 year ago

As @oshoval suggested in https://github.com/kubevirt/cluster-network-addons-operator/pull/1499, I will parameterize thees in CNAO. closing this PR