Closed oshoval closed 1 year ago
/cc @RamLavi
Can you run it manually to see that the label doesn't "return" unannounced by kustomize?
Can you run it manually to see that the label doesn't "return" unannounced by kustomize?
Good point, tried, it doesn't
we should also include running make generate on the unit-test if we don't already
Can you run it manually to see that the label doesn't "return" unannounced by kustomize?
Good point, tried, it doesn't
good. /lgtm /approve
we should also include running make generate on the unit-test if we don't already
not sure, but it's a good idea
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: RamLavi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thanks, once there will be a release we can update a little CNAO code (for now we can just remove the code on the 1st bullet)
no rush
What this PR does / why we need it: Following https://github.com/kubevirt/cluster-network-addons-operator/pull/1145/files#r796372158 We don't need this label on KMP, and it require busy work on CNAO (see linked issue below). Hence remove it from the namespace.
Note: the 2nd commit is manual removing from the files, where
make generate
didn't remove from.Special notes for your reviewer: See first bullet at https://github.com/kubevirt/cluster-network-addons-operator/issues/1567
Release note: