k8snetworkplumbingwg / kubemacpool

Apache License 2.0
32 stars 33 forks source link

manifests: Remove control-plane label from namespace #389

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

What this PR does / why we need it: Following https://github.com/kubevirt/cluster-network-addons-operator/pull/1145/files#r796372158 We don't need this label on KMP, and it require busy work on CNAO (see linked issue below). Hence remove it from the namespace.

Note: the 2nd commit is manual removing from the files, where make generate didn't remove from.

Special notes for your reviewer: See first bullet at https://github.com/kubevirt/cluster-network-addons-operator/issues/1567

Release note:

None
oshoval commented 1 year ago

/cc @RamLavi

RamLavi commented 1 year ago

Can you run it manually to see that the label doesn't "return" unannounced by kustomize?

oshoval commented 1 year ago

Can you run it manually to see that the label doesn't "return" unannounced by kustomize?

Good point, tried, it doesn't

we should also include running make generate on the unit-test if we don't already

RamLavi commented 1 year ago

Can you run it manually to see that the label doesn't "return" unannounced by kustomize?

Good point, tried, it doesn't

good. /lgtm /approve

we should also include running make generate on the unit-test if we don't already

not sure, but it's a good idea

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)~~ [RamLavi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oshoval commented 1 year ago

Thanks, once there will be a release we can update a little CNAO code (for now we can just remove the code on the 1st bullet)

no rush