search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
32 stars 33 forks source link

check hashicorp: Add hashicorp whitelist #394

Closed oshoval closed 11 months ago

oshoval commented 11 months ago

What this PR does / why we need it: Validates that no hashicorp are used beside the whitelisted ones (because they shifted to BSL license)

Special notes for your reviewer: Atm no hashicorp is used, but lets protect in case someone will add. Based on the whitelist that CNAO uses.

Need to validate git actions runs it on next PRs, as this is the first one. (git actions is enabled)

Release note:

None
kubevirt-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)~~ [RamLavi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oshoval commented 11 months ago

It seems git actions isnt configured correctly, as it had to run it already even before it is merged if you can take a look please ?