search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
32 stars 33 forks source link

chore: Update golang.org/x/* modules and rework tests #398

Closed 0xFelix closed 10 months ago

0xFelix commented 10 months ago

What this PR does / why we need it:

Updated modules golang.org/x/* to the latest versions.

To allow go mod tidy to work again the dependency on kubevirt.io/kubevirt and the broken replacement of gopkg.in/k8snetworkplumbingwg/multus-cni.v3 are removed.

Special notes for your reviewer:

Release note:

None
kubevirt-bot commented 10 months ago

Hi @0xFelix. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mhenriks commented 10 months ago

/lgtm

kubevirt-bot commented 10 months ago

@mhenriks: changing LGTM is restricted to collaborators

In response to [this](https://github.com/k8snetworkplumbingwg/kubemacpool/pull/398#issuecomment-1781629576): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
oshoval commented 10 months ago

Very nice thanks /lgtm

RamLavi commented 10 months ago

/approve

kubevirt-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)~~ [RamLavi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment