k8snetworkplumbingwg / kubemacpool

Apache License 2.0
32 stars 33 forks source link

[release-v0.38] Update dependencies #400

Closed 0xFelix closed 10 months ago

0xFelix commented 10 months ago

What this PR does / why we need it:

Updated modules golang.org/x/*, github.com/containernetworking/cni and github.com/emicklei/go-restful to the latest versions.

The broken replacement of github.com/openshift/api and github.com/openshift/client-go are fixed by replacing them with the version used in main.

Updates of github.com/containernetworking/cni are allowed again by removing the dependency on kubevirt.io/kubevirt.

Special notes for your reviewer:

Release note:

None
kubevirt-bot commented 10 months ago

Hi @0xFelix. Thanks for your PR.

I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
oshoval commented 10 months ago

/ok-to-test

oshoval commented 10 months ago

error: unable to read URL "https://github.com/kubevirt/kubevirt/releases/download//kubevirt-operator.yaml", server reported 404 Not Found, status code=404

will check if the link missing version or so

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/k8snetworkplumbingwg_kubemacpool/400/pull-kubemacpool-e2e-k8s-v0.38/1718929886808117248

EDIT - https://github.com/k8snetworkplumbingwg/kubemacpool/pull/403 trying to fix here

oshoval commented 10 months ago

/test pull-kubemacpool-e2e-k8s-v0.38

oshoval commented 10 months ago

/retest

qinqon commented 10 months ago

/lgtm /approve

kubevirt-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/release-v0.38/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment