Closed 0xFelix closed 10 months ago
Hi @0xFelix. Thanks for your PR.
I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/test all
@oshoval: No presubmit jobs available for k8snetworkplumbingwg/kubemacpool@release-0.33
There are no presubmits here .. @phoracek @RamLavi should we add those ? (it means we will need to take the ones that the future version uses, either 0.38 (4.11) or to try the closest to 0.33
Adding here, lets see it pass on vanilla release note that it uses very old k8s-1.21 https://github.com/kubevirt/project-infra/pull/3040
/hold
until we run presubmits
/test all
/hold cancel
/cc @RamLavi can you please review?
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: qinqon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
Updated modules golang.org/x/*, github.com/containernetworking/cni, github.com/emicklei/go-restful and github.com/prometheus/client_golang to the latest versions
To accomplish this the golang version was bumped to 1.17.
The broken replacement of github.com/openshift/api and github.com/openshift/client-go are fixed by replacing them with the version used in main.
Updates of github.com/containernetworking/cni are allowed again by removing the dependency on kubevirt.io/kubevirt.
Special notes for your reviewer:
Release note: