search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
32 stars 33 forks source link

[release-0.33] cluster-up: Fix kubevirt deploy #402

Closed oshoval closed 10 months ago

oshoval commented 10 months ago

What this PR does / why we need it: The logic to get latest z stream is outdated for v0.44 as the release file doesnt have full history for old versions. Fetch manually the latest z stream for the used version.

Special notes for your reviewer:

Release note:

None
oshoval commented 10 months ago

Tested here https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3040/rehearsal-pull-kubemacpool-e2e-k8s-0.33/1718950024836026368

qinqon commented 10 months ago

/lgtm /approve

kubevirt-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/release-0.33/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oshoval commented 10 months ago

Note: Presumits are added here https://github.com/kubevirt/project-infra/pull/3040 but it depends on this PR, and was tested on CI with both (link above)