search

k8snetworkplumbingwg / kubemacpool

Apache License 2.0
35 stars 33 forks source link

Bump kube-rbac-proxy #404

Closed oshoval closed 10 months ago

oshoval commented 11 months ago

What this PR does / why we need it: Includes https://github.com/openshift/kube-rbac-proxy/pull/80

Special notes for your reviewer:

Release note:

None
oshoval commented 11 months ago

/cc @RamLavi

RamLavi commented 11 months ago

Can you please update the commit desc? Or is it a WIP PR that is only meant to confirm CNAO?

oshoval commented 11 months ago

Done, not a WIP anymore, just forgot to update it is not dependent on CNAO, and not vice versa CNAO just replace whatever it is to what CNAO wants

oshoval commented 11 months ago

Interesting here https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/k8snetworkplumbingwg_kubemacpool/404/pull-kubemacpool-e2e-k8s/1723649479040569344

I dont think it is related to the PR kube-rbac-proxy is a side car container that listens to the http metrics port and convert it to https, protected by rbac

btw few days ago there was also this one (on other PR) in this area more or less

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1678/pull-e2e-cnao-kubemacpool-functests-release-0.89/1721495335496323072

If you want i can open issue for those 2

oshoval commented 10 months ago

/retest

not related to this PR imo

qinqon commented 10 months ago

/lgtm /approve

kubevirt-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/k8snetworkplumbingwg/kubemacpool/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment