k8snetworkplumbingwg / multi-net-spec

Multi-network CRD specification
45 stars 12 forks source link

Update section 4.1.2.1.4 mac #8

Open adrianchiris opened 4 years ago

adrianchiris commented 4 years ago

Quoting the Spec for network CRD:

4.1.2.1.4 "mac" This optional key with value type string requires the plugin handling this network attachment to assign the given MAC address to the pod. This key’s value must contain a valid 6-byte Ethernet MAC address or a valid 20-byte IP-over-InfiniBand Hardware address (as described in RFC4391 section 9.1.1). If the value is invalid, the Network Attachment Selection Annotation shall be invalid and ignored by the implementation.

According to section 9.1.1 of IPoIB (IP over Infiniband) RFC an infiniband hardware address consists of 20 octets in the following format:

As the only element which is user configurable is the 8 byte GUID (Infiniband's version of MAC address) we should reword this section essentially removing the bits related to IP-Over-Infiniband.

It should be noted that it is still possible (and expected) for an IP over Infiniband CNI to return the full 20 octet hardware address under mac field which will be visible in network-status annotation, hence that part of the network CRD spec should not need changing.

I have created an issue in containernetworking/cni proposing to allow the configuration of the GUID part of the IPoIB hardware address. if and when it gets approved, support for it in multi-net-spec will be dealt with in this issue.

adrianchiris commented 4 years ago

following the nwpg meeting we had last week, would you prefer to open a google doc for it ? (if yes, please specify what should be in the doc.)

Essentially i think we could simply modify the section as follows (simply remove the IP over Infiniband bits):

4.1.2.1.4 "mac" This optional key with value type string requires the plugin handling this network attachment to assign the given MAC address to the pod. This key’s value must contain a valid 6-byte Ethernet MAC address. If the value is invalid, the Network Attachment Selection Annotation shall be invalid and ignored by the implementation.

Then if/once there is agreement on GUID configuration, we can update the doc again to reflect the latest changes.

adrianchiris commented 4 years ago

@dcbw I have created a google doc with the proposed change, comments welcome.

adrianchiris commented 4 years ago

@dcbw inputs are welcomed :)

adrianchiris commented 4 years ago

This change was approved on NPWG meeting on 04.06.2020

Is there a periodic update of the spec ? as changes are not proposed directly to the source file.