coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 2910989139
- 70 of 100 (70.0%) changed or added relevant lines in 2 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage increased (+0.4%) to 50.653%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| pkg/server/policyrules.go | 70 | 71 | 98.59% | ||
| pkg/server/server.go | 0 | 29 | 0.0% | ||
| <!-- | Total: | 70 | 100 | 70.0% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| pkg/server/server.go | 1 | 2.64% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 2820429741: | 0.4% |
| Covered Lines: | 892 |
| Relevant Lines: | 1761 |
zeeke
This PR fixes issue https://github.com/k8snetworkplumbingwg/multi-networkpolicy-iptables/issues/22 .
It leverage commits from (not mandatory but strongly encouraged)
Changes mostly consist of calling iptableBuffer twice, once for IPv4 and one for IPv6.
I think it's also time to refactor the complexity of
iptableBuffer.renderIngressFrom(...)andiptableBuffer.renderEgressTo(...), but we can also get it in a different PR.