search

k8snetworkplumbingwg / multi-networkpolicy-iptables

MultiNetworkPolicy iptable based implementation
Apache License 2.0
13 stars 19 forks source link

Graceful shutdown for daemonset #32

Closed zeeke closed 1 year ago

zeeke commented 1 year ago

Graceful shutdown allows cleaning iptable rules in pods.

Open points:

This PR also contain a small refactor about Options and Server interactions.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3134879745

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/server/options.go 0 5 0.0%
pkg/server/server.go 0 13 0.0%
<!-- Total: 0 18 0.0% -->
Files with Coverage Reduction New Missed Lines %
pkg/server/options.go 1 0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 3092084100: -0.09%
Covered Lines: 862
Relevant Lines: 1691
💛 - Coveralls
zeeke commented 1 year ago

Honestly, no idea how to unit test these changes, as they are about the application lifecycle. Maybe some bash scripting on top of https://github.com/zeeke/multi-networkpolicy-iptables/tree/e2e-testing could help.