Closed zeeke closed 11 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/server/server.go | 5 | 13 | 38.46% | ||
<!-- | Total: | 5 | 13 | 38.46% | --> |
Totals | |
---|---|
Change from base Build 5523838027: | 5.1% |
Covered Lines: | 1104 |
Relevant Lines: | 1886 |
e2e-kind
job is fixed by:
@zeeke Appreciated your e2e test fix! Could you please rebase the PR to get the e2e fix?
@zeeke I update the PR but e2e still failed. PTAL?
ok 1 setup simple test environments
ok 2 test-simple-v4-ingress-list check client-a -> server
not ok 3 test-simple-v4-ingress-list check client-b -> server
# (in test file tests/simple-v4-ingress-list.bats, line 35)
# `[ "$status" -eq "1" ]' failed
Sure, I'll have a look
Some tests were missing a sleep after the test setup. I think some assertions were running before the server policy sync.
@zeeke thank you for the quick fix! Let's merge that.
In cases where Spec.PolicyTypes is not specified, it should default to the existence of Ingress or Egress rules.
Updating end2end tests to cover also this scenario.
Changes have been guided by the regular NetworkPolicy documentation: