k8snetworkplumbingwg / multi-networkpolicy-iptables

MultiNetworkPolicy iptable based implementation
Apache License 2.0
13 stars 19 forks source link

Fix end2end tests #53

Closed zeeke closed 11 months ago

zeeke commented 11 months ago

Flakiness we are experiencing in:

are because of the multinetwork-policy-iptables binary is built in golang:1.20 and run in centos:centos7, producing an error like:

2023-07-07T08:35:03.719070939Z stderr F /usr/bin/multi-networkpolicy-iptables: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /usr/bin/multi-networkpolicy-iptables)

This PR, beside fixing the above error by setting CGO_ENABLED=0 [1], make kind logs available for debugging purpose in case of test failure.

[1] https://stackoverflow.com/a/64531740

coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 5484722898


Files with Coverage Reduction New Missed Lines %
pkg/server/policyrules.go 2 87.53%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 5401125977: -0.1%
Covered Lines: 1008
Relevant Lines: 1885

💛 - Coveralls