search

k8snetworkplumbingwg / multi-networkpolicy

Apache License 2.0
19 stars 11 forks source link

change EndPort type to *int32 #21

Closed l8huang closed 4 months ago

l8huang commented 8 months ago

This change is for aligning type with NetworkPolicyPort, this could make the conversion from MultiNetworkPolicy to NetworkPolicyPort easier.

l8huang commented 8 months ago

@s1061123 could you please take a look?

s1061123 commented 7 months ago

Hi @l8huang, thank you so much for the PR. Could you please take a look into my comment? Almost Okey, so I'll approve once you incorporate my comment.

l8huang commented 7 months ago

Hi @s1061123 , thanks for looking at this PR, your comment addressed, could you please take a look?

l8huang commented 7 months ago

@s1061123 please kindly let know if it's okay to you? Thanks.

s1061123 commented 5 months ago

@l8huang sorry for the late reply. It looks good to me, so after fixing CI, I will merge that.

l8huang commented 4 months ago

@s1061123 Thanks for getting this PR merged.

I have some questions regard to versioning, created a issue for that: https://github.com/k8snetworkplumbingwg/multi-networkpolicy/issues/23. Could you please take a look?